Set the type for S_ISUID, S_ISGID and S_ISVTX correctly #503
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks for the PR! Unfortunately this runs a relatively high risk of being a breaking change, so we may not be able to accept this until the next major version :( |
|
That's fair. For the record, this is related to a nix cleanup I am working. I would be surprised if anybody except nix depends on those constants, but I guess it is better to be safe than sorry. How far are you from the next major version? |
|
We don't currently have a timeline for the next major release, unfortunately, but it's likely to happen at some point at least. |
Fix the style for bitflags! Prefer `libc_bitflags!` over `bitflags!`. Prefer `libc::CONSTANTS` over writing the constant manually. This makes rust-lang#501 unnecessary, since upstream now contains the `O_TMPFILE` constant.
|
@TethysSvensson could you rebase this? We can give this a try and see if it breaks anybody. |
|
@gnzlbg Done! |
|
@bors: r+ |
|
📌 Commit 457b0f9 has been approved by |
Set the type for S_ISUID, S_ISGID and S_ISVTX correctly
Set the type for S_ISUID, S_ISGID and S_ISVTX correctly
|
☀️ Test successful - checks-cirrus, checks-travis, status-appveyor |
Fuchsia's definitions of these constants were split from the unix impls before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly typed as c_int instead of mode_t. This applies the same fix to Fuchsia's constant definitions to bring them in line with the rest of libc.
Fuchsia's definitions of these constants were split from the unix impls before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly typed as c_int instead of mode_t. This applies the same fix to Fuchsia's constant definitions to bring them in line with the rest of libc.
Fuchsia's definitions of these constants were split from the unix impls before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly typed as c_int instead of mode_t. This applies the same fix to Fuchsia's constant definitions to bring them in line with the rest of libc.
Fuchsia's definitions of these constants were split from the unix impls before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly typed as c_int instead of mode_t. This applies the same fix to Fuchsia's constant definitions to bring them in line with the rest of libc.
Fuchsia's definitions of these constants were split from the unix impls before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly typed as c_int instead of mode_t. This applies the same fix to Fuchsia's constant definitions to bring them in line with the rest of libc.
No description provided.