Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose futimens() for illumos systems #1607

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Conversation

jclulow
Copy link
Contributor

@jclulow jclulow commented Nov 27, 2019

illumos has an implementation of futimens() which we should expose. I'm working on a broader set of fixes for illumos in general, but that's going to take a lot more work to be ready so the test suite doesn't currently seem to function.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 27, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 27, 2019

📌 Commit ca3eb03 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 27, 2019

⌛ Testing commit ca3eb03 with merge 077dfb2...

bors added a commit that referenced this pull request Nov 27, 2019
expose futimens() for illumos systems

illumos has an implementation of `futimens()` which we should expose.  I'm working on a broader set of [fixes for illumos](master...jclulow:illumos_fixes) in general, but that's going to take a lot more work to be ready so the test suite doesn't currently seem to function.
@bors
Copy link
Contributor

bors commented Nov 27, 2019

💔 Test failed - status-azure

@jclulow
Copy link
Contributor Author

jclulow commented Nov 27, 2019

Apologies for missing the style check. I'll fix it up.

@gnzlbg
Copy link
Contributor

gnzlbg commented Nov 28, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 28, 2019

📌 Commit 223e7d3 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Nov 28, 2019

⌛ Testing commit 223e7d3 with merge 88f6587...

bors added a commit that referenced this pull request Nov 28, 2019
expose futimens() for illumos systems

illumos has an implementation of `futimens()` which we should expose.  I'm working on a broader set of [fixes for illumos](master...jclulow:illumos_fixes) in general, but that's going to take a lot more work to be ready so the test suite doesn't currently seem to function.
@bors
Copy link
Contributor

bors commented Nov 28, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 88f6587 to master...

@bors bors merged commit 223e7d3 into rust-lang:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants