Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add struct ip_mreqn to more Linux targets #1903

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Add struct ip_mreqn to more Linux targets #1903

merged 1 commit into from
Sep 30, 2020

Conversation

bartelsielski
Copy link
Contributor

Support was previously added to GNU x86_64 and all musl targets but others were not included because of a roundtrip issue.

This commit adds support for the ip_mreqn struct on all Linux GNU targets which did not have the roundtrip issue.

Support was previously added to gnu x86_64 and all musl targets but
others were not included because of a roundtrip issue [1].

This commit adds support for the ip_mreqn struct on all Linux GNU
targets which did not have the roundtrip issue.

[1]: #1558

Signed-off-by: Bartel Sielski <bartel.sielski@gmail.com>
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@JohnTitor
Copy link
Member

Looks good, let's re-trigger CI as the current is spurious.

@JohnTitor JohnTitor closed this Sep 30, 2020
@JohnTitor JohnTitor reopened this Sep 30, 2020
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now green, thanks!

@JohnTitor JohnTitor merged commit b3f8975 into rust-lang:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants