Move Linux's POLLRDHUP into linux_like and fix its type.
#2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
|
I'm not sure how many users are affected by this change but I'd like to follow our breaking change policy, just in case: https://github.com/rust-lang/libc/blob/master/CONTRIBUTING.md#breaking-change-policy |
sunfishcode
force-pushed
the
sunfishcode/linux-pollrdhup
branch
from
84aae8c
to
3b9a06a
Compare
|
Sounds good. I've now changed the PR to just introduce |
`POLLRDHUP` erroneously has type `c_int`. To prepare for changing it to `c_short` (and also moving it to `src/unix/linux_like` so that it's available on Android as well), mark it as deprecated.
sunfishcode
force-pushed
the
sunfishcode/linux-pollrdhup
branch
from
3b9a06a
to
5fb0c2e
Compare
JohnTitor
approved these changes
Sep 12, 2021
|
Thanks! |
|
📌 Commit 5fb0c2e has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
sunfishcode
added a commit
to sunfishcode/libc
that referenced
this pull request
Oct 27, 2021
This was originally posted as rust-lang#2390, but since it was a breaking change, that PR instead just added `deprecated` warnings. There haven't been any concerns for a while, so this is now a PR to do the change actually, per the [breaking-change-policy]. This fixes two errors in rust-lang#2247. - It moves the definitions of `POLLRDHUP` out of `linux_like/linux` and into `linux_like`, so that they're available on Android as well. - It changes the type from `c_int` to `c_short` to match the other `POLL*` flags. [breaking-change-policy]: https://github.com/rust-lang/libc/blob/master/CONTRIBUTING.md#breaking-change-policy
bors
added a commit
that referenced
this pull request
Oct 30, 2021
…Titor Move Linux's `POLLRDHUP` into `linux_like` and fix its type. This was originally posted as #2390, but since it was a breaking change, that PR instead just added `deprecated` warnings. There haven't been any concerns for a while, so this is now a PR to do the change actually, per the [breaking-change-policy]. This fixes two errors in #2247. - It moves the definitions of `POLLRDHUP` out of `linux_like/linux` and into `linux_like`, so that they're available on Android as well. - It changes the type from `c_int` to `c_short` to match the other `POLL*` flags. [breaking-change-policy]: https://github.com/rust-lang/libc/blob/master/CONTRIBUTING.md#breaking-change-policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two errors in #2247.
It moves the definitions of
POLLRDHUPout oflinux_like/linuxand into
linux_like, so that they're available on Android as well.It changes the type from
c_inttoc_shortto match the otherPOLL*flags.This second change is a breaking change, and I'm fine reverting it and
leaving it as the old type if that's the right thing to do.