Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add futimes on Android #2843

Closed
wants to merge 1 commit into from

Conversation

joshtriplett
Copy link
Member

No description provided.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Jul 12, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jul 12, 2022

📌 Commit 72f5b39 has been approved by Amanieu

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jul 12, 2022
@bors
Copy link
Contributor

bors commented Jul 12, 2022

⌛ Testing commit 72f5b39 with merge a2400f0...

@bors
Copy link
Contributor

bors commented Jul 12, 2022

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Jul 12, 2022

The emscripten target is set up as a "linuxlike" target which is causing this to fail since it doesn't have this function.

@Amanieu
Copy link
Member

Amanieu commented Jul 13, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jul 13, 2022

📌 Commit 2a6ca0a has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 13, 2022

⌛ Testing commit 2a6ca0a with merge 133531d...

bors added a commit that referenced this pull request Jul 13, 2022
@bors
Copy link
Contributor

bors commented Jul 13, 2022

💔 Test failed - checks-actions

@Amanieu
Copy link
Member

Amanieu commented Jul 13, 2022

I think you're hitting the same problem as #2758: we're using an old image for Android and can't figure out how to make CI work with a newer image. You can just whitelist the symbol in libc-test/build.rs for now.

@JohnTitor
Copy link
Member

@joshtriplett Friendly-ping, could you address the above comment?

@bors
Copy link
Contributor

bors commented Oct 25, 2022

☔ The latest upstream changes (presumably #2974) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnTitor
Copy link
Member

Triage: Closing as inactive. Feel free to reopen/resubmit if you're still interested in this PR. Thanks!

@JohnTitor JohnTitor closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants