Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PF_ROUTE-related structures on Apple systems #3206

Merged
merged 1 commit into from
May 6, 2023
Merged

Add PF_ROUTE-related structures on Apple systems #3206

merged 1 commit into from
May 6, 2023

Conversation

roblabla
Copy link
Contributor

This commit adds the following structures from net/route.h:

  • rt_msghdr
  • rt_msghdr2
  • rt_metrics

and the following structures from net/if.h:

  • ifa_msghdr
  • ifma_msghdr
  • ifma_msghdr2

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@roblabla roblabla changed the title Add PF_ROUTE structures on Apple systems Add PF_ROUTE-related structures on Apple systems Apr 19, 2023
@JohnTitor
Copy link
Member

The test still fails, could you check?
@rustbot author

@roblabla
Add PF_ROUTE structures on Apple systems
404ad40 
This commit adds the following structures from net/route.h:

- rt_msghdr
- rt_msghdr2
- rt_metrics

and the following structures from net/if.h:

- ifa_msghdr
- ifma_msghdr
- ifma_msghdr2
@roblabla
Copy link
Contributor Author

roblabla commented Apr 25, 2023 •
edited
Loading

And this is why I shouldn't trust apple's manpages. They are filled with lies, lies and more lies 😂. man 4 route, and the header disagree on the order of fields.

Anyhow, this should be all fixed now.

@JohnTitor
Copy link
Member

Thank you! @bors r+

@bors
Copy link
Contributor

bors commented May 6, 2023

📌 Commit 404ad40 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 6, 2023

⌛ Testing commit 404ad40 with merge e5d9339...

@bors
Copy link
Contributor

bors commented May 6, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing e5d9339 to master...

@bors bors merged commit e5d9339 into rust-lang:master May 6, 2023
@nyurik
Copy link
Contributor

nyurik commented Jul 30, 2024

@roblabla I'm not certain if this is related, but CI no longer passes on MacOS, and all errors relate to rmx_state and other MacOS specific stuff. Any idea what might be causing it? Thx!

@roblabla
Copy link
Contributor Author

roblabla commented Jul 31, 2024 •
edited
Loading

rmx_state was removed in macOS 14.4. #3776 fixes the CI by ignore that field in the validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roblabla @rustbot @JohnTitor @bors @nyurik