-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haiku: fix incorrect linked library. #3222
Conversation
Introduced in fb2a763; using a non-existent "libunix". This is in libgnu.
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
I'm not familiar with Haiku so just to confirm, should every Haiku users have the libgnu, i.e. does it need an additional setup? If it should it's fine. |
Haiku has non-posix extensions in libbsd and libgnu; they're part of the system, however. |
Can confirm that this fixes the build, the incorrect linking was introduced in #3165. |
It should be fine then, thanks for clarifying! @bors r+ |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
1 similar comment
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Introduced in fb2a763; using a non-existent "libunix". This is in libgnu.