Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use build-std=core instead of build-std alone #3292

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

GuillaumeGomez
Copy link
Member

Should help with #3289.

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@jyn514
Copy link
Member

jyn514 commented Jul 5, 2023

have you tested locally that cargo doc-Zbuild-std=core works? please don't test by publishing, i only have limited time to help.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jul 5, 2023

Yes, tested with two targets:

$ cargo doc -Zbuild-std=core --target=arm-linux-androideabi
    Updating crates.io index
   Compiling compiler_builtins v0.1.92
   Compiling core v0.0.0 (/home/imperio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core)
   Compiling libc v0.2.147 (/home/imperio/rust/libc)
   Compiling rustc-std-workspace-core v1.99.0 (/home/imperio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/rustc-std-workspace-core)
 Documenting libc v0.2.147 (/home/imperio/rust/libc)
    Finished dev [unoptimized + debuginfo] target(s) in 9.69s

$ cargo doc -Zbuild-std=core --target=aarch64-linux-android
   Compiling compiler_builtins v0.1.92
   Compiling core v0.0.0 (/home/imperio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core)
   Compiling libc v0.2.147 (/home/imperio/rust/libc)
   Compiling rustc-std-workspace-core v1.99.0 (/home/imperio/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/rustc-std-workspace-core)
 Documenting libc v0.2.147 (/home/imperio/rust/libc)
    Finished dev [unoptimized + debuginfo] target(s) in 8.47s

Do you want me to test something else just in case?

@jyn514
Copy link
Member

jyn514 commented Jul 5, 2023

that seems fine - but just fyi most of the failures i mentioned #3289 (comment) are probably going to continue to be issues

@GuillaumeGomez
Copy link
Member Author

It's fine for now. I can take a look at them later on, it's less pressing than the current state. ^^'

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Jul 9, 2023

📌 Commit bcecfe5 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 9, 2023

⌛ Testing commit bcecfe5 with merge 1a612bb...

@bors
Copy link
Contributor

bors commented Jul 9, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 1a612bb to main...

1 similar comment
@bors
Copy link
Contributor

bors commented Jul 9, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 1a612bb to main...

@bors
Copy link
Contributor

bors commented Jul 9, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit 1a612bb into rust-lang:main Jul 9, 2023
@GuillaumeGomez GuillaumeGomez deleted the build-std-core branch July 9, 2023 17:29
@GuillaumeGomez
Copy link
Member Author

eyes Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

Anything I need to do about this?

@JohnTitor
Copy link
Member

JohnTitor commented Jul 9, 2023

The commit was pushed anyway so we don't have to do anything (I believe this is a bug/weird behavior of bors, I remember seeing this message on the rust repo).

EDIT: Well, it seems the message is a bit different from what I've ever seen. Anyway, the main branch should have this change and we can call it a day unless any additional commits are missing.

@GuillaumeGomez
Copy link
Member Author

Noted, thanks for checking! Don't hesitate if I need to fix something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants