Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eventfd_read/write for Android/FreeBSD/Linux #3436

Closed
wants to merge 1 commit into from

Conversation

SteveLauC
Copy link
Contributor

Add

int eventfd_read(int fd, eventfd_t *value);
int eventfd_write(int fd, eventfd_t value);

for

@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@SteveLauC
Copy link
Contributor Author

This FreeBSD 12 CI failure is for the reason that these things are added in FreeBSD 13

From the lesson I learned from my last PR, even though a symbol is not available for 12, we should also put it in the freebsd/mod.rs

Friendly ask, what should we do about this case :<

@devnexen
Copy link
Contributor

This FreeBSD 12 CI failure is for the reason that these things are added in FreeBSD 13

From the lesson I learned from my last PR, even though a symbol is not available for 12, we should also put it in the freebsd/mod.rs

Friendly ask, what should we do about this case :<

The way I see it, something along those lines in libc-test/build.rs in appropriate places :

"eventfd_t" if Some(13) > freebsd_ver => true,

same for the calls.

@JohnTitor
Copy link
Member

Looks good, could you squash commits into one?

@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2023

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@SteveLauC SteveLauC closed this Nov 12, 2023
@SteveLauC
Copy link
Contributor Author

Accidentally broke my branch, move this PR to #3437

For the OpenBSD and Solarish maintainers, I am sorry about the ping, please ignore it

@SteveLauC SteveLauC deleted the enentfd_read/write branch November 12, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants