expose solarish's SFV_FD_SELF for sendfilev purpose #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
|
I am not sure that this is quite right. Have you been able to get the test suite to pass on an illumos machine? |
devnexen
force-pushed
the
solarish_self_fd
branch
from
3d44948
to
5422ee0
Compare
|
oddily enough, the test fail for me locally for native_getpwent_r/native_getgrent_t but the linkname setting should prevent that. |
devnexen
force-pushed
the
solarish_self_fd
branch
from
5422ee0
to
6fb545a
Compare
|
test pass now with last test fixes. |
pfmooney
approved these changes
Nov 29, 2023
JohnTitor
approved these changes
Nov 30, 2023
|
@bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.