hurd: Fix build from missing fpos_t
#4472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 872642a ("gnu: Add proper structs for fpos_t and fpos64_t"), `fpos_t` was changed from an opaque struct to one with a definition on Linux GNU, with the Unix fallback configured as for targets without a GNU `target_env`. However, GNU hurd matches `target_env = "gnu"`, but doesn't have a `fpos` implementation. Fix the build by adjusting the fallback `cfg` to be more specific. Eventually we probably want the same definition on Hurd as on Linux.
tgross35
added
stable-nominated
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
hurd: Fix build from missing `fpos_t`
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 3, 2025
In 872642a ("gnu: Add proper structs for fpos_t and fpos64_t"), `fpos_t` was changed from an opaque struct to one with a definition on Linux GNU, with the Unix fallback configured as for targets without a GNU `target_env`. However, GNU hurd matches `target_env = "gnu"`, but doesn't have a `fpos` implementation. Fix the build by adjusting the fallback `cfg` to be more specific. Eventually we probably want the same definition on Hurd as on Linux. (backport <rust-lang#4472>) (cherry picked from commit 72f49c9)
Merged
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 3, 2025
In 872642a ("gnu: Add proper structs for fpos_t and fpos64_t"), `fpos_t` was changed from an opaque struct to one with a definition on Linux GNU, with the Unix fallback configured as for targets without a GNU `target_env`. However, GNU hurd matches `target_env = "gnu"`, but doesn't have a `fpos` implementation. Fix the build by adjusting the fallback `cfg` to be more specific. Eventually we probably want the same definition on Hurd as on Linux. (backport <rust-lang#4472>) (cherry picked from commit 72f49c9)
tgross35
added
stable-applied
DorianNiemiecSVRJS
pushed a commit
to DorianNiemiecSVRJS/rust-libc
that referenced
this pull request
Jun 21, 2025
In 872642a ("gnu: Add proper structs for fpos_t and fpos64_t"), `fpos_t` was changed from an opaque struct to one with a definition on Linux GNU, with the Unix fallback configured as for targets without a GNU `target_env`. However, GNU hurd matches `target_env = "gnu"`, but doesn't have a `fpos` implementation. Fix the build by adjusting the fallback `cfg` to be more specific. Eventually we probably want the same definition on Hurd as on Linux. (backport <rust-lang#4472>) (cherry picked from commit 72f49c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 872642a ("gnu: Add proper structs for fpos_t and fpos64_t"),
fpos_twas changed from an opaque struct to one with a definition on Linux GNU, with the Unix fallback configured as for targets without a GNUtarget_env. However, GNU hurd matchestarget_env = "gnu", but doesn't have afposimplementation.Fix the build by adjusting the fallback
cfgto be more specific. Eventually we probably want the same definition on Hurd as on Linux.