libc: Switch Haiku to ctest, remove ctest_old dependency and src-hotfix directory
#4681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbyx
force-pushed
the
libc-port-haiku
branch
from
0956d71 to
878a505
Compare
mbyx
changed the title
ctest and remove ctest_old dependencyctest, remove ctest_old dependency and src-hotfix directory
|
This LGTM, but could you split into two different commits? One updating Haiku, one removing the hotfix and ctest. (Usually it's best to split orthogonal changes to separate commits; makes the summaries easier to write and the blame/log is easier to understand, and in our case it means that specific changes can be backported). |
mbyx
force-pushed
the
libc-port-haiku
branch
from
878a505 to
dd4cc27
Compare
|
Done! |
tgross35
added
the
stable-nominated
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4681>) (cherry picked from commit 13190a4)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4681>) (cherry picked from commit 78196ba)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4681>) (cherry picked from commit 13190a4)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4681>) (cherry picked from commit 78196ba)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4681>) (cherry picked from commit 13190a4)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4681>) (cherry picked from commit 78196ba)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4681>) (cherry picked from commit 13190a4)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 22, 2025
(backport <rust-lang#4681>) (cherry picked from commit 78196ba)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports Haiku to use the new
ctest, so that everything now depends on this newctest.It also removes the creation of the src-hotfix directory, since it's no longer needed.
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI