Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement asin #7

Closed
japaric opened this issue Jul 12, 2018 · 1 comment · Fixed by #107
Closed

implement asin #7

japaric opened this issue Jul 12, 2018 · 1 comment · Fixed by #107
Labels
core also part of the core milestone
Milestone
wasm

Comments

@japaric
Copy link
Member

japaric commented Jul 12, 2018

Source: https://git.musl-libc.org/cgit/musl/tree/src/math/asin.c
@japaric japaric added the help wanted Extra attention is needed label Jul 12, 2018
@japaric japaric added this to the wasm milestone Jul 12, 2018
@japaric japaric added the core also part of the core milestone label Jul 12, 2018
vjackson725 added a commit to vjackson725/libm that referenced this issue Jul 14, 2018
@vjackson725
add an implemetation of asin
f6b9dac 
Fixes rust-lang#7

Additonally adds inline functions for macros dealing with low and high words of f64s to the root module.

Also, the muslc code used a hexdecimal float. This shouldn't be needed because Rust implements
floating point parsing well.
vjackson725 added a commit to vjackson725/libm that referenced this issue Jul 14, 2018
@vjackson725
add an implemetation of asin
f0c206c 
Fixes rust-lang#7

Additonally adds inline functions for macros dealing with low and high words of f64s to the root module.

Also, the muslc code used a hexdecimal float. This shouldn't be needed because Rust implements
floating point parsing well.
@vjackson725 vjackson725 mentioned this issue Jul 14, 2018
Closed
@japaric
Copy link
Member Author

japaric commented Jul 14, 2018

PR #95 implements this

@japaric japaric removed the help wanted Extra attention is needed label Jul 14, 2018
japaric pushed a commit that referenced this issue Jul 14, 2018
@vjackson725 @japaric
add an implemetation of asin
600a238 
Fixes #7

Additonally adds inline functions for macros dealing with low and high words of f64s to the root module.

Also, the muslc code used a hexdecimal float. This shouldn't be needed because Rust implements
floating point parsing well.
@japaric japaric mentioned this issue Jul 14, 2018
Merged
bors bot added a commit that referenced this issue Jul 14, 2018
@bors @vjackson725
Merge #107
6d7626c 
107: add an implemetation of asin r=japaric a=japaric

Fixes #7

Additonally adds inline functions for macros dealing with low and high words of f64s to the root module.

Also, the muslc code used a hexdecimal float. This shouldn't be needed because Rust implements
floating point parsing well.

---

rebased version of #95
closes #95
Thanks @vjackson725 for the original PR!

Co-authored-by: vjackson725 <vjackson725@users.noreply.github.com>
@bors bors bot closed this as completed in #107 Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core also part of the core milestone
Projects
None yet
Milestone
wasm
Development

Successfully merging a pull request may close this issue.

add an implemetation of asin rust-lang/libm
1 participant
@japaric