add an implemetation of asin #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#7 Additonally adds inline functions for macros dealing with low and high words of f64s to the root module. Also, the muslc code used a hexdecimal float. This shouldn't be needed because Rust implements floating point parsing well.
|
Whoops, I misinterpreted the hex floating point literal as a subtraction. Fixed now. |
japaric
suggested changes
Jul 14, 2018
| } | ||
|
|
||
| #[inline] | ||
| pub fn with_set_high_word(f: f64, hi: u32) -> f64 { |
There was a problem hiding this comment.
I think it would be more rustic to write this as fn set_high_word(f: &mut f64, hi: u32).
There was a problem hiding this comment.
Actually, this is fine given how it's actually used
| } | ||
|
|
||
| #[inline] | ||
| pub fn with_set_low_word(f: f64, lo: u32) -> f64 { |
There was a problem hiding this comment.
above comment applies here as well
bors bot
added a commit
that referenced
this pull request
Jul 14, 2018
107: add an implemetation of asin r=japaric a=japaric Fixes #7 Additonally adds inline functions for macros dealing with low and high words of f64s to the root module. Also, the muslc code used a hexdecimal float. This shouldn't be needed because Rust implements floating point parsing well. --- rebased version of #95 closes #95 Thanks @vjackson725 for the original PR! Co-authored-by: vjackson725 <vjackson725@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Additionally adds inline functions for macros dealing with low and high words of f64s to the root module.
I'm not sure if you want these, but they seem sufficiently different to
get_bitsto merit a separate function.Tell me if I need to change anything!