This repository was archived by the owner on Feb 5, 2019. It is now read-only.
[Sparc] Include __tls_get_addr in symbol table for TLS calls to it #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global Dynamic and Local Dynamic call relocations only implicitly reference __tls_get_addr, but it still needs to be in the symbol table to be bound at link time otherwise it fails to link. For details, see https://sourceware.org/bugzilla/show_bug.cgi?id=22832.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream fix for LLVM on SPARC which is currently in review:
This fix is required to fix the code generation in LLVM on SPARC. Without the patch, LLVM generates incorrect code over which binutils stumble and bail out with an internal error, see:
The patch has already been merged in the Debian packages for LLVM 4.0, 5.0 and 6.0.
CC @jrtc27