Skip to content

Conversation

Eijebong
Copy link
Contributor

The former has been deprecated in favor of the latter

@Eijebong
Copy link
Contributor Author

I didn't include a version bump in there because I don't know what the right thing to do is (since it's in an alpha version and all :p).
It would be nice to have this released quickly as it's one of the last thing that's keeping winapi 0.2 in rustc

@Michael-F-Bryan
Copy link
Contributor

Thanks for the PR @Eijebong, I never noticed that tempdir has been deprecated.

I didn't include a version bump in there because I don't know what the right thing to do is

The tempdir crate is just an internal implementation detail of mdbook and not exposed anywhere, so there's no need for a version bump.

It would be nice to have this released quickly as it's one of the last thing that's keeping winapi 0.2 in rustc

Works for me. It looks like you forgot to update a bunch of things in the tests/ directory, but as soon as all the tests pass again we should be good to merge.

@Eijebong
Copy link
Contributor Author

Yup, I'm on it ^_^ forgot to check that cargo test was compiling

The former has been deprecated in favor of the latter
@Eijebong
Copy link
Contributor Author

There we go

@Michael-F-Bryan Michael-F-Bryan merged commit 55f7ed1 into rust-lang:master Mar 26, 2018
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
The former has been deprecated in favor of the latter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants