Fix #4579 by checking if the strong protector is actually "active". #4580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to Miri! |
This comment has been minimized.
This comment has been minimized.
…active". Where "active" means that the accessed bit is set. This also reverts miri PR 3831.
JoJoDeveloping
force-pushed
the
fix-4579-protector-0sized
branch
from
b39ece4 to
14dc656
Compare
RalfJung
reviewed
Sep 11, 2025
There was a problem hiding this comment.
This could become part of the basic_aliasing_model test, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where "active" means that the accessed bit is set.
Fixes #4579. This also reverts #3831, or rather turns this into a must-pass test.