-
Notifications
You must be signed in to change notification settings - Fork 91
Update nightly toolchain and Cargo.lock
, fix examples broken by stabilized features
#473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! I think you need to update rust-toolchain.toml to get CI to pass. |
Update examples to remove features that have been stabilized
Ah, I manually overrode it locally to 08-17. Pushed the toolchain fix, but I think Blog post for its removal in the 1.86 release notes
|
This comment was marked as resolved.
This comment was marked as resolved.
Cargo.lock
, fix examples broken by stabilized features
Updated the original PR comment. I removed the i586 target from the CI job and ran |
Miri failed on float equality tests. No idea how to resolve that. |
i think the failures are caused by rust-lang/miri#3555 I don't have time right now to fix all that myself, so @okaneco you can try to fix it or let one of us try (@calebzulawski?) |
I'm working on a fix :) |
51932e7
to
9183dcf
Compare
Trying to get that Not sure if you wanted to use that flag, |
433c7d2
to
1ce33dd
Compare
I added approximate comparisons, I think this should work... |
Thanks! :) |
It looks like Miri did end passing with the I noticed while looking in the Miri job logs that there were warnings for pointer to int conversions, so might want to set -Dwarnings in rustflags to notice them faster unless it's intended.
Lastly, there are arm64 runners available for Windows and Ubuntu now. It was too complicated to add to this PR but the macos step could turn into the aarch64 job (adjusting for the darwin-x86 target). |
When will this be synced to rust-lang/rust? |
I might want to work through the open PRs but I can do it sooner if it's blocking something |
Not blocking anything important on my side. Just wanted to know when I could revert a minor workaround in cg_clif's build system. |
Bump toolchain to
nightly-2025-08-17
Update Cargo.lock
Remove the deprecated
i586-pc-windows-msvc
target from CIFix examples broken by
slice_as_chunks
being stabilized andarray_chunks
being removed in favor ofas_chunks
Fixes #470