Skip to content

Establish Infrastructure #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Establish Infrastructure #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f6d11c
make rustc_public a `crates.io` crate
makai410 Aug 20, 2025
00ce048
establish infrastructrure
makai410 Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions .github/scripts/run_own_tests.sh
View file
Open in desktop

This file was deleted.

116 changes: 0 additions & 116 deletions .github/scripts/run_rustc_tests.sh
View file
Open in desktop

This file was deleted.

7 changes: 5 additions & 2 deletions .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Rust Toolchain
uses: dtolnay/rust-toolchain@nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need nightly for format check?


- name: Run Rust Format
run: cargo fmt --check
run: ./x fmt --check
41 changes: 21 additions & 20 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,29 @@ on:
workflow_dispatch: # Allow manual dispatching
pull_request:

defaults:
run:
shell: bash

jobs:
compile-test:
name: Rust Compiler Tests
msrv:
name: MSRV Nightly Tests
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Install latest nightly
uses: actions-rs/toolchain@v1
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly

- name: Test local suites
run: ./.github/scripts/run_own_tests.sh
env:
TOOLS_BIN: "/tmp/smir/bin"
# Note that the downloaded version is dated 2025-08-09.
toolchain: nightly-2025-08-10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a toolchain toml file, as we'll update it frequently and that's easier to automate than editing a github workflow

Fine for now tho if you want to land this first and tune later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah makes sense. I'd like to update it later together with the automation pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that be a follow up PR?

components: rust-src
- run: ./x test

- name: Test rustc suites
run: ./.github/scripts/run_rustc_tests.sh
env:
RUST_REPO: "/tmp/rustc"
TOOLS_BIN: "/tmp/smir/bin"
# Don't fail CI for now. See: https://github.com/rust-lang/project-stable-mir/issues/39
continue-on-error: true
latest:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, you should be able to create an action and reuse it for these two jobs. Not a big deal at this point, but if you have a follow up PR, that might be a nice change.

I also want to add a test for latest stable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, you should be able to create an action and reuse it for these two jobs. Not a big deal at this point, but if you have a follow up PR, that might be a nice change.

Yes, that would be done as follow up

I also want to add a test for latest stable

ummm iirc the stable version can’t enable rustc_private

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People would still need to set bootstrap env variable

name: Latest Nightly Tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@nightly
with:
components: rust-src
- run: ./x test
6 changes: 6 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
/book/build
**/target

# direnv
.envrc
/.direnv

.idea
*.swp
*.swo
.vscode

Cargo.lock
8 changes: 4 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# Cargo workspace for utility tools used to check stable-mir in CI
[workspace]
resolver = "2"
members = [
"tools/compiletest",
"tools/test-drive",
"devtool",
"rustc_public",
"test-drive",
]

exclude = [
"build",
"target",
"demo",
"target",
]
12 changes: 12 additions & 0 deletions devtool/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[package]
name = "devtool"
version = "0.0.0"
authors = ["rustc_public team"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/rust-lang/project-stable-mir"
edition = "2021"

[dependencies]
anyhow = "1.0.99"
clap = { version = "4.1.3", features = ["derive"] }
xshell = "0.2.6"
Loading