Skip to content

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Jan 3, 2019

Fixes #497.

Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tomorrow came quickly... ;)

Some suggestions:

Centril and others added 6 commits January 2, 2019 20:34
Co-Authored-By: chriskrycho <hello@chriskrycho.com>
Co-Authored-By: chriskrycho <hello@chriskrycho.com>
Co-Authored-By: chriskrycho <hello@chriskrycho.com>
Co-Authored-By: chriskrycho <hello@chriskrycho.com>
Co-Authored-By: chriskrycho <hello@chriskrycho.com>
@chriskrycho
Copy link
Contributor Author

Yeah, I realized I was more motivated to push this than to clean the dishes! 😆

@Centril
Copy link
Contributor

Centril commented Jan 3, 2019

Haha; I sympathize with not cleaning the dishes ;)

This turned out great; thanks!

@Centril Centril merged commit 692f694 into rust-lang:master Jan 3, 2019
@chriskrycho chriskrycho deleted the const-evaluation-467 branch January 3, 2019 03:45
@chriskrycho
Copy link
Contributor Author

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants