Fix #215. #216
Merged
Fix #215. #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most prominently, this reduces the threshold at which backtracking will run. It looks like giving it much more room than this ends up making it run slower than the Pike VM because of the zeroing that has to be done before searching. In the process, we get rid of the "max program size" and "max input" distinction. What we want to optimize for is the total size of the state table, so do that instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most prominently, this reduces the threshold at which backtracking will
run. It looks like giving it much more room than this ends up making it
run slower than the Pike VM because of the zeroing that has to be done
before searching.
In the process, we get rid of the "max program size" and "max input"
distinction. What we want to optimize for is the total size of the state
table, so do that instead.