Fix replace_all when only match is at start and replacement is empty. #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this! This was a pretty silly mistake on my part! |
|
@bors r+ |
|
📌 Commit a9f9c9c has been approved by |
|
💔 Test failed - status-travis |
|
@bors retry |
|
💔 Test failed - status-travis |
|
@bors retry |
|
☀️ Test successful - status-appveyor, status-travis |
|
will a new version including this fix be pushed automatically to crates.io or someone has to trigger that manually? thanks |
|
@maximih I'm working on it. I'll issue a release once #323 is merged. |
|
@maximih 0.2.1 is out! |
|
@BurntSushi thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314.
All old tests and the new test I added pass, and I also confirmed manually that the test case reported in #314 passes with this change. Let me know if you can think of any case that my change doesn't handle!