Skip to content

Conversation

seeekr
Copy link
Contributor

@seeekr seeekr commented Jan 18, 2017

No description provided.

src/backtrack.rs Outdated
const MAX_SIZE_BYTES: usize = 256 * (1 << 10); // 256 KB

/// Returns true iff the given regex and input should be executed by this
/// Returns true if the given regex and input should be executed by this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually isn't a typo. "iff" is vernacular for "if and only if." If you get rid of this change, I'll merge the other. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh -- thanks for teaching me something new, never came across that before! I'll remove that change then!

@seeekr
Copy link
Contributor Author

seeekr commented Jan 19, 2017

invalid fix removed!

@BurntSushi
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 19, 2017

📌 Commit 0263a18 has been approved by BurntSushi

@BurntSushi
Copy link
Member

Thanks!

@bors
Copy link
Contributor

bors commented Jan 19, 2017

⌛ Testing commit 0263a18 with merge 014bdea...

bors added a commit that referenced this pull request Jan 19, 2017
@bors
Copy link
Contributor

bors commented Jan 19, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: BurntSushi
Pushing 014bdea to master...

@bors bors merged commit 0263a18 into rust-lang:master Jan 19, 2017
@seeekr seeekr deleted the patch-1 branch January 19, 2017 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants