document compile contract #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal documentaion is a little lighter than usual in `src/compile.rs`, so I wrote up the impression of the compilation contract I developed by reading the code. This is honestly a thinly veiled way to check my own understanding of what is going on. Hopefully it will be valuable to the next person who starts digging into the compiler.
|
I'm going to close this because it isn't really needed. |
|
@ethanpailes Oh man, I'm sorry for missing this. I didn't even know this PR existed. Would you mind re-opening it? I'd love to merge it as is. :-) |
|
Absolutely! |
|
@ethanpailes Sweet thanks so much! |
|
@bors r+ |
|
📌 Commit 2076c71 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 22, 2017
document compile contract The internal documentaion is a little lighter than usual in `src/compile.rs`, so I wrote up the impression of the compilation contract I developed by reading the code. This is honestly a thinly veiled way to check my own understanding of what is going on. Hopefully it will be valuable to the next person who starts digging into the compiler.
|
☀️ Test successful - status-appveyor, status-travis |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal documentaion is a little lighter than
usual in
src/compile.rs, so I wrote up the impressionof the compilation contract I developed by reading the
code. This is honestly a thinly veiled way to check my
own understanding of what is going on. Hopefully it will
be valuable to the next person who starts digging into
the compiler.