Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_empty() to RegexSet. #687

Closed
wants to merge 1 commit into from

Conversation

@HammockSunburn
Copy link
Contributor

@HammockSunburn HammockSunburn commented Jun 1, 2020

Implementing is_empty() on RegexSet makes the API similar to standard
library collections like Vec and BTreeSet. The clippy lint
len_without_is_empty recommends that items which implement len()
should implement is_empty().

Implementing `is_empty()` on RegexSet makes the API similar to standard
library collections like `Vec` and `BTreeSet`. The clippy lint
`len_without_is_empty` recommends that items which implement `len()`
should implement `is_empty()`.
BurntSushi added a commit that referenced this pull request Oct 11, 2020
This adheres to standard conventions for collections of things.

Closes #687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant