Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with pattern feature #772

Merged
merged 4 commits into from May 6, 2021

Conversation

Luro02
Copy link
Contributor

@Luro02 Luro02 commented May 5, 2021

No description provided.

Copy link
Member

@BurntSushi BurntSushi left a comment

Thanks! It looks like the CI setup might need to be tweaked a bit though.

test Outdated Show resolved Hide resolved
@BurntSushi
Copy link
Member

BurntSushi commented May 5, 2021

Looks like the unicode-perl feature is needed to run the searcher tests.

GitHub Actions CI is FUBAR, so it doesn't run until I click a button. Please run the tests locally and make sure it works there before pushing.

@Luro02 Luro02 requested a review from BurntSushi May 6, 2021
@BurntSushi BurntSushi merged commit 11543fd into rust-lang:master May 6, 2021
10 checks passed
@BurntSushi
Copy link
Member

BurntSushi commented May 6, 2021

This PR is on crates.io in regex 1.5.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants