rfcbot should actually trigger FCPs, update comment text

[anp]

@aturon, #61 (comment):

Quick question/request: when the bot posts comments like rust-lang/rfcs#1682 (comment), AFAICT it's "going into FCP" in its own head (in that, according to the docs, it'll post a follow-up comment one week later). One problem is, it's not actually flagging the RFC as final-comment-period, and the comment it leaves is a little unclear.

After discussion with @nikomatsakis, we feel comfortable with the bot fully triggering FCP, given our experience so far. That would mean:

• Tagging the issue as final-comment-period
• Posting a very clear comment saying: "This RFC is now entering its final comment period, as per the review above", with a link back to the original checklist.

A couple other details:

The bot should post another comment, "The final comment period is now complete." after one "business week" has passed since going into FCP. Actually merging the RFC requires human intervention, since we want to review intervening comments.
...

---

Yes, it's "going into FCP" in its head. I didn't want the text to be too authoritative while we're trying it out, but I can definitely update that.

Tagging as final-comment-period is a little tricky, because I believe there are some permissions that need to be set up on any applicable repos. I can write the code such that it will fail gracefully if the tagging isn't permitted (allowing it to still work smoothly on non-permitted repos)?

How is a business week defined here? I'm just doing 7 days right now, which means that excepting three-day weekends there should always be 5 business days between FCP start and end.

[aturon]

So the "business week" thing was mostly thinking about "This Week in Rust", which is where a lot of people find out about FCP. That usually goes out on Monday, sometimes Tuesday.

I think what I'm asking for is that FCP last until the nearest Sunday that is at least one week away... but that's a bit complex.

Probably a simpler approach would just be to say FCP lasts for 10 days, or something like that.

[anp]

Gotcha. 10 days is totally doable -- and makes a lot more sense once I have time to generalize the dashboard. That should be a quick change to make.

[aturon]

Regarding tagging/permissions: I think this is worthwhile. We've had cases where we've forgotten to tag an RFC and thus delayed action by more than a week. Automating as much as we can is great.

If the tagging fails, it'd be great if the bot's comment can say something like "I was unable to tag final-comment-period; please do so". That'll also alert us to the repos where we need to set up these permissions.

[anp]

Yes, failing gracefully-but-not-silently sounds great.

[aturon]

Applying the final-comment-period label is a high priority item.

[anp]

@aturon this is pretty much ready to try out, but I haven't yet finished setting up the optional & variable-length FCPs. Which means that PRs which shouldn't have an FCP will still have the label applied. Should I wait to deploy this change until the command structure is built out?

[aturon]

Yay! I think we should go forward with this change -- better to get extra
final-comment-period labels than not enough, IMO.

Thanks!

On Mon, Oct 24, 2016 at 11:29 PM, Adam Perry notifications@github.com
wrote:

@aturon https://github.com/aturon this is pretty much ready to try out,
but I haven't yet finished setting up the optional & variable-length FCPs.
Which means that PRs which shouldn't have an FCP will still have the label
applied. Should I wait to deploy this change until the command structure is
built out?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#86 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArUr7dJFUJC9WS1tb20Guo41hC5jZJkks5q3aHSgaJpZM4KQsAF
.

[anp]

This has been deployed, I'll keep an eye out for any breakage.