Switch from travis to github actions. #3136
Conversation
.github/workflows/deploy.yml
Outdated
| - name: Install mdbook | ||
| run: | | ||
| mkdir mdbook | ||
| curl -Lf https://github.com/rust-lang/mdBook/releases/download/v0.4.8/mdbook-v0.4.8-x86_64-unknown-linux-gnu.tar.gz | tar -xz --directory=./mdbook |
There was a problem hiding this comment.
Hm, this will cause RFCs book to use 0.4.8 probably almost indefinitely this way. Maybe good, but definitely a different from the previous setup.
There was a problem hiding this comment.
I personally prefer to lock versions so that it doesn't break or otherwise have silent issues in the future. I do not know of a way to get notifications for errors pushing to master. And some issues with mdbook could just be rendering problems where a manual inspection is required. This is also substantially faster to run.
However, if infra would prefer to update on each push, I can easily add that.
There was a problem hiding this comment.
Mkdir mdbook Curl - Lf http://github.com/rust-lang/mdbook/releases/download/v0. 4.8/mdbook-v0. 4.8-x86_64-known-linux-gnu.tar.gz|tar -xz --directory =>/mdbook . Gethub/workflow/deploy. Yml
|
@rustbot modify labels to +not-rfc |
|
Error: This repository is not enabled to use triagebot. Please let |
ehuss
added
the
not-rfc
Travis shut down travis.org, and travis.com doesn't automatically get enabled. Rather than enabling travis.com, I figure it would be better to just switch to GitHub Actions.