Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract module into file changed module visibility #7712

Closed
GopherJ opened this issue Feb 18, 2021 · 1 comment
Closed

extract module into file changed module visibility #7712

GopherJ opened this issue Feb 18, 2021 · 1 comment
Labels
A-assists E-has-instructions Issue has some instructions and pointers to code to get started S-actionable Someone could pick this issue up and work on it right now

Comments

@GopherJ
Copy link

GopherJ commented Feb 18, 2021

Peek 2021-02-18 12-00
@Veykril Veykril added A-assists S-actionable Someone could pick this issue up and work on it right now labels Feb 18, 2021
@Veykril
Copy link
Member

Veykril commented Feb 18, 2021

Relevant code that discards the visibility https://github.com/rust-analyzer/rust-analyzer/blob/20a911f3cc2beb0409ab71cc1560648374745f7f/crates/assists/src/handlers/move_module_to_file.rs#L62

@Veykril Veykril added the E-has-instructions Issue has some instructions and pointers to code to get started label Feb 18, 2021
bors bot added a commit that referenced this issue Feb 20, 2021
@bors @mattyhall
Merge #7730
364d572 
7730: Fix #7712 retain visibility extracting mod to file r=lnicola a=mattyhall



Co-authored-by: Matt Hall <matthew@quickbeam.me.uk>
@bors bors bot closed this as completed in b963893 Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-assists E-has-instructions Issue has some instructions and pointers to code to get started S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Veykril @GopherJ