Skip to content

Fix .let completion not work for let-chain #20526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix .let completion not work for let-chain #20526

wants to merge 1 commit into from

Conversation

A4-Tacks
Copy link
Contributor

@A4-Tacks A4-Tacks commented Aug 24, 2025 •
edited by rustbot
Loading

Fixes #20749

Example

fn main() {
    let bar = Some(true);
    if true && bar.$0
}

Before this PR:

Cannot complete .let

After this PR:

fn main() {
    let bar = Some(true);
    if true && let Some($0) = bar
}

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2025
@A4-Tacks A4-Tacks changed the title Add .let postfix completion in let-chain support Fix .let completion not work for let-chain Sep 26, 2025
@A4-Tacks
Fix .let completion not work for let-chain
38fed17 
Example
---
```rust
fn main() {
    let bar = Some(true);
    if true && bar.$0
}
```

**Before this PR**:

Cannot complete `.let`

**After this PR**:

```rust
fn main() {
    let bar = Some(true);
    if true && let Some($0) = bar
}
```
@A4-Tacks A4-Tacks force-pushed the postfix-let-in-let-chain branch from afbecea to 38fed17 Compare September 26, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postfix completion .let cannot work for let-chain
2 participants
@A4-Tacks @rustbot