minor: Fix one more thing in in-rust-tree
#20695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
approved these changes
Sep 18, 2025
|
BTW we have several other errors beside this that complaining we are missing a field in a constructor of a type in |
|
How can that be? Don't tell me |
lnicola
changed the title
in-rust-treein-rust-tree
rustbot
removed
the
S-waiting-on-review
|
Oh, it's gated by |
Oh, we're in a tight spot |
|
Nah, it's fine, thanks to your awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this is the last thing for the errors like
Foo and Foo have similar names, but are actually distinct types🙃We might need CI that runs cargo check with
in-rust-treefeature and check whether we are usingra_ap_*things