internal: Migrate more predicate things to next-solver #20717
Conversation
rustbot
added
the
S-waiting-on-review
| // Skipping the inner binders is ok, as we don't handle quantified where | ||
| // clauses yet. | ||
| .into_value_and_skipped_binders(); | ||
| stdx::always!(b.len(Interner) == 0); |
There was a problem hiding this comment.
dumb question, but should we keep this assert around in some form?
There was a problem hiding this comment.
I think we wouldn't need it here. db.generic_predicates(..) returns chalk_ir's Binder and this assertion checks whether there exists any HRTB among such predicates, as Binders - both chalk's and rustc's - may contain such things.
But the migrated db.generic_predicates_ns(..) returns EarlyBinder, which doesn't contain any HRTBs because EarlyBinder primarily exists to remind that we have to instantiate it before using it.
EarlyBinders would be more appropriate in this context but unfortunately chalk_ir doesn't have EarlyBinder so I guess because of that we currently have such assertion here.
There was a problem hiding this comment.
Oh, I was a bit wrong. db.generic_predicates_ns(..) returns EarlyBinderGenericPredicates. But anyway, it's not a Binder so don't need to keep the assertion and anyway they are bound into EarlyBinder and then instantiated to be used both in our codebase and rustc.
ShoyuVanilla
force-pushed
the
migrate-more
branch
from
b6bbbdf to
196bd25
Compare
ShoyuVanilla
force-pushed
the
migrate-more
branch
from
196bd25 to
0a5457a
Compare
rustbot
removed
the
S-waiting-on-review
Originally started this to migrate
TraitEnvironmentto next-solver but it needs few more touches 😅 (Will do it after this)