Skip to content

minor: Fix small things clippy was complaining about #20778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
+3 −8
Merged

minor: Fix small things clippy was complaining about #20778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a6e472
Fix two small things clippy was complaining about
itsjunetime Oct 2, 2025
8e350c5
Get rid of unfulfilled expectation
itsjunetime Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/ide-completion/src/completions/attribute/cfg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pub(crate) fn complete_cfg(acc: &mut Completions, ctx: &CompletionContext<'_>) {
"target_os" => KNOWN_OS.iter().copied().for_each(add_completion),
"target_vendor" => KNOWN_VENDOR.iter().copied().for_each(add_completion),
"target_endian" => ["little", "big"].into_iter().for_each(add_completion),
name => ctx.krate.potential_cfg(ctx.db).get_cfg_values(name).cloned().for_each(|s| {
name => ctx.krate.potential_cfg(ctx.db).get_cfg_values(name).for_each(|s| {
let s = s.as_str();
let insert_text = format!(r#""{s}""#);
let mut item = CompletionItem::new(
Expand Down
8 changes: 2 additions & 6 deletions crates/ide-db/src/assists.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,14 +170,10 @@ impl AssistResolveStrategy {
#[derive(Clone, Debug)]
pub struct GroupLabel(pub String);

#[derive(Clone, Debug, PartialEq, Eq)]
#[derive(Clone, Debug, PartialEq, Eq, Default)]
pub enum ExprFillDefaultMode {
#[default]
Todo,
Default,
Underscore,
}
impl Default for ExprFillDefaultMode {
fn default() -> Self {
Self::Todo
}
}
1 change: 0 additions & 1 deletion crates/stdx/src/thread.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ impl<T> Drop for JoinHandle<T> {
}
}

#[expect(clippy::min_ident_chars, reason = "trait impl")]
impl<T> fmt::Debug for JoinHandle<T> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
f.pad("JoinHandle { .. }")
Expand Down