Support yield keyword #7209
Merged
Support yield keyword #7209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
to rust-analyzer/ungrammar
that referenced
this pull request
Jan 12, 2021
19: Add YieldExpr r=lnicola a=sasurau4 Adding YieldExpr Part of rust-lang/rust-analyzer#7209 ref: https://doc.rust-lang.org/beta/unstable-book/language-features/generators.html Co-authored-by: Daiki Ihara <sasurau4@gmail.com>
|
|
|
As a heads up since you haven't touched that part here before either, to make the parser support the yield syntax you will have to add the parsing for it at the correct places in the https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/parser/src/grammar/expressions/atom.rs module. |
sasurau4
force-pushed
the
feature/add-generator-keywords
branch
2 times, most recently
from
38550ac to
d2fb5a5
Compare
lnicola
reviewed
Jan 13, 2021
sasurau4
force-pushed
the
feature/add-generator-keywords
branch
from
d2fb5a5 to
b557ea7
Compare
|
@Veykril Thanks for guiding! |
Veykril
reviewed
Jan 14, 2021
| Expr::Return { expr } => { | ||
| Expr::Return { expr } | Expr::Yield { expr } => { | ||
| if let Some(expr) = expr { | ||
| self.infer_expr_coerce(*expr, &Expectation::has_type(self.return_ty.clone())); |
There was a problem hiding this comment.
This doesn't apply to yield I think. A generator may have a return type and a yield type that aren't the same. To properly implement inference for yield we need to track the yield type in the InferenceContext I believe but that can be done in a separate PR I'd say.
So for now we probably want something like this:
Expr::Yield { expr } => {
// FIXME: track yield type for coercion
if let Some(expr) = expr {
self.infer_expr(expr, &Expectation::none());
}
Ty::simple(TypeCtor::Never)
}
sasurau4
force-pushed
the
feature/add-generator-keywords
branch
from
b557ea7 to
138514b
Compare
|
lgtm 👍 |
This was referenced Apr 3, 2024
osiewicz
pushed a commit
to zed-industries/zed
that referenced
this pull request
Apr 4, 2024
Release Notes: - Added `yield` keyword highlight for Rust Ref: - rust-lang/rust-analyzer#7209 - https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/syntax_highlighting/highlight.rs#L177 - https://doc.rust-lang.org/reference/keywords.html?highlight=yield#reserved-keywords In VS Code:  docs.rs: https://docs.rs/async-stream/latest/async_stream/macro.try_stream.html  ## Before <img width="644" alt="image" src="https://github.com/zed-industries/zed/assets/5518/da349187-57e6-4cea-b3e3-f628ce6a99e8"> ## After update in Zed 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4309
The inference of yield will be implemented at another PR.