Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: Disable conditionally class constants #2

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jun 22, 2016

Part of the fix for #1

@@ -152,6 +157,8 @@ pub struct BindgenOptions {
pub enable_cxx_namespaces: bool,
pub rename_types: bool,
pub derive_debug: bool,
/// Werther to generate C++ class constants.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether

bors-servo pushed a commit to servo/rust-mozjs that referenced this pull request Jun 23, 2016
Fix linux 64bit bindings which included inline symbols

This requires rust-lang/rust-bindgen#2 and rust-lang/rust-bindgen#3 to run bindgen, but does not need to wait on those to land as the new bindings are included here.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/271)
<!-- Reviewable:end -->
@emilio
Copy link
Contributor Author

emilio commented Jun 23, 2016

Done

@larsbergstrom
Copy link

@bors-servo try

@larsbergstrom
Copy link

@bors-servo try retry clean

@emilio
Copy link
Contributor Author

emilio commented Jun 30, 2016

re-r? @nox

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 1, 2016

@bors-servo r+

@bors-servo
Copy link

📌 Commit 33270a9 has been approved by Ms2ger

@highfive highfive assigned Ms2ger and unassigned nox Jul 1, 2016
@bors-servo
Copy link

⌛ Testing commit 33270a9 with merge 7726d5a...

bors-servo pushed a commit that referenced this pull request Jul 1, 2016
parser: Disable conditionally class constants

Part of the fix for #1
@bors-servo
Copy link

☀️ Test successful - travis

@bors-servo bors-servo merged commit 33270a9 into master Jul 1, 2016
@Ms2ger Ms2ger deleted the class-consts branch July 1, 2016 12:46
@jvo203 jvo203 mentioned this pull request Jan 27, 2019
benesch pushed a commit to benesch/rust-bindgen that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants