Rebase #1740 upon master #2229
Closed
Rebase #1740 upon master #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulp
force-pushed
the
clang_tooling_rebased
branch
from
0ecc203 to
17febdc
Compare
|
This passes |
kulp
force-pushed
the
clang_tooling_rebased
branch
3 times, most recently
from
6bb29b6 to
4575fab
Compare
|
As of 4575fab there is one CI job passing all tests with Clang 9.0. Right now this requires a lot of hacks to |
This comment was marked as resolved.
This comment was marked as resolved.
kulp
force-pushed
the
clang_tooling_rebased
branch
from
c107881 to
357c865
Compare
This reverts commit c462892. This turned out not to be used, and causes trouble with rust-lang#1740.
Bindgen builds and runs now, but does not produce any bindings yet.
We need to compare on variant contents, not just on variant equality
Bindgen currently assumes that it won't see these types from libclang.
Added some misc CXXBaseSpecifier accessors and fixed visiting CXXBaseSpecifiers
Needed for compatibility with latest Clang
Platforms don't mangle C++ the same, so we should avoid depending on C++ mangling if we're going to embed a bindings file.
We can't pass C++ objects by value from C++ to Rust. QualType has an interface for converting back and forth to void*, so we can use that instead.
bindgen -o src/clang/clang_interface.rs --no-copy 'BindgenStringRef.*' --no-copy BindgenSourceRange --translate-enum-integer-types --default-enum-style moduleconsts --no-doc-comments src/clang/clang_interface.hpp -- -I/home/linuxbrew/.linuxbrew/opt/llvm/include/
kulp
force-pushed
the
clang_tooling_rebased
branch
from
357c865 to
c4e8dfe
Compare
|
☔ The latest upstream changes (presumably ef2ee38) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental rebase of #1740 upon the current master, a1a0043.
Most commits do not compile or pass tests, and many have been modified during the rebase.
The current PR is, in itself, not likely a candidate for eventual merging, but it might help illuminate a path forward.