feat: add headers option
#2743
Merged
feat: add headers option
#2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
reviewed
Feb 4, 2024
bindgen/options/mod.rs
Outdated
| where I::Item: Into<String>{ | ||
| self.options.input_headers | ||
| .extend(headers.into_iter().map(Into::into).map(Into::into)); | ||
| self |
There was a problem hiding this comment.
May be a bit simpler to do:
for h in headers {
self = self.header(h);
}
self
But I guess this is fine as well, your call.
There was a problem hiding this comment.
My main concern was that the additional moves could have some sort of performance impact? Likely that's not a concern. I've left it as is, but let me know if you disagree and I can change it.
Problem: It's cumbersome to define multiple input headers using the existing `header` API. It's difficult for the user to configure the `Builder` with a list of input headers. Solution: Add `headers` method that permits adding multiple headers via an iterable of Strings. Testing: Added `test_headers_call_in_builder`. Ran `cargo test` in `bindgen-tests/tests/expectations`. Issue: rust-lang#2738
emilio
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: It's cumbersome to define multiple input headers using the existing
headerAPI. It's difficult for the user to configure theBuilderwith a list of input headers.Solution: Add
headersmethod that permits adding multiple headers via an iterable of Strings.Testing: Added
test_headers_call_in_builder. Rancargo testinbindgen-tests/tests/expectations.Issue: #2738