-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
C-enhancementCategory: Enhancement of lints, like adding more cases or adding help messagesCategory: Enhancement of lints, like adding more cases or adding help messagesgood first issueThese issues are a good way to get started with ClippyThese issues are a good way to get started with Clippy
Description
Consider this:
enum Foo(u8) { // Probably struct as well
_1, _2, ...
}
impl Foo {
unsafe fn add(self, rhs: u8) -> Foo { ... }
}
This triggers should_implement_trait
, which a false positive, as Add
requires a normal function, not an unsafe one.
cargo clippy -V
:
clippy 0.0.212 (4ee12063 2020-02-01)
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: Enhancement of lints, like adding more cases or adding help messagesCategory: Enhancement of lints, like adding more cases or adding help messagesgood first issueThese issues are a good way to get started with ClippyThese issues are a good way to get started with Clippy