Add unnecessary_literal_unwrap lint

[pksunkara]

Add lint for more unnecessary unwraps and suggest fixes for them.

Fixes #10352

• Followed [lint naming conventions][lint_naming]
• Added passing UI tests (including committed .stderr file)
• cargo test passes locally
• Executed cargo dev update_lints
• Added lint documentation
• Run cargo dev fmt

r? @llogiq

---

changelog: New lint [unnecessary_literal_unwrap]
#10358

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information.

[llogiq]

The unwrap_or_else_default UI test is still failing.

[llogiq]

@rustbot author

[samueltardieu]

The unwrap_or_else_default UI test is still failing.

As well as many others. I count differences in 21 output files when testing locally.

[pksunkara]

Only the documentation is left. But before I do that, I would like to know 2 things:

1. How do I make this lint warn by default?
2. What should I put in place of #[clippy::version = "1.45.0"] in declare_lint! usage?

[bors]

☔ The latest upstream changes (presumably #10528) made this pull request unmergeable. Please resolve the merge conflicts.

[llogiq]

@pksunkara do you intend to revisit this at some point?

[pksunkara]

Yup, I can take a look on Monday.

[pksunkara]

I would appreciate if I can get some answers for the questions I asked earlier, #10358 (comment)

[llogiq]

1. How do I make this lint warn by default?
2. What should I put in place of #[clippy::version = "1.45.0"] in declare_lint! usage?

1. Do you mean in a test? That would be #[warn(clippy::unnecessary_literal_unwrap)]. Otherwise the default lint level is given by the lint group. As this lint is in complexity, that should IIRC warn by default.
2. #[clippy::version = "1.69.0"].

[pksunkara]

I have addressed the review comments.

@rustbot reviewer

[rustbot]

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[blyxyas]

@pksunkara The comment to remove the L-waiting-on-author label is rustbot ready

[llogiq]

There are still merge conflicts, and I don't have time to review right now, sorry. Perhaps I'll find a few minutes tomorrow.

[pksunkara]

There are still merge conflicts

They are very minor ones because of this PR touching a lot of tests and I will fix them once the code is reviewed.

[llogiq]

Looks good, I only have a small nit regarding docs.

Also I'm not completely sure about the name: So far we have 23 needless-* and 18 unnecessary-* lints. I like the former more for both brevity and being easier to write.

[pksunkara]

Addressed the conflicts and review comment.

[bors]

☔ The latest upstream changes (presumably #10921) made this pull request unmergeable. Please resolve the merge conflicts.

[llogiq]

So you intend to keep the name longer. Ah, well, you've done enough rebases as is. Let's roll with it. Thanks for seeing this PR through.

@bors r+

[bors]

📌 Commit bfd5aba has been approved by llogiq

It is now in the queue for this repository.

[bors]

⌛ Testing commit bfd5aba with merge 7c2bf28...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 7c2bf28 to master...