-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog for Rust 1.73 ποΈ #11605
Conversation
r? @blyxyas (rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:3
CHANGELOG.md
Outdated
[#10120](https://github.com/rust-lang/rust-clippy/pull/10120) | ||
* Moved [`tuple_array_conversions`] to `pedantic` (Now allow-by-default) | ||
[#11171](https://github.com/rust-lang/rust-clippy/pull/11171) | ||
* Moved [`arc_with_non_send_sync`] to `complexity` (Now warn-by-default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was actually moved to suspicious
πββ¬
* Moved [`needless_raw_string_hashes`] to `pedantic` (Now allow-by-default) | ||
[#11415](https://github.com/rust-lang/rust-clippy/pull/11415) | ||
|
||
### Enhancements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#10120 also now handles more functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a bunch of enhancements, like this one, which I have skipped. I have the feeling that this doesn't add much of value. Just reading that, doesn't tell me which functions. If I'm interested in a specific one, I would have been subscribed to the issue and would know about the fix. If I have the lint enabled and it warns about more cases, I will just be happy. I don't see users specifically enabling a lint because they read something like that, you know.
That was the motivation for making the changelogs more summery like and linking to all merged PRs for the really interested users.
If you think this should really be included, it can of course be added,
|
||
* Renamed `unwrap_or_else_default` to [`unwrap_or_default`] | ||
[#10120](https://github.com/rust-lang/rust-clippy/pull/10120) | ||
* Moved [`tuple_array_conversions`] to `pedantic` (Now allow-by-default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm #11171 isn't the PR that changes it to pedantic
, it's actually there from this commit, but I'm not sure why that commit is there, we should do some more investigation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I get for putting trust in the changelog
entries in the PR description. I found the correct PR: #11146
CHANGELOG.md
Outdated
[#11049](https://github.com/rust-lang/rust-clippy/pull/11049) | ||
* [`manual_is_finite`] | ||
[#11049](https://github.com/rust-lang/rust-clippy/pull/11049) | ||
* [`non_canonical_partial_ord_impl`] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the lint introduced in #10788 is incorrect_partial_ord_impl_on_ord_type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was renamed later, but apparently after the release cutoff. I expected the rename to be backported as it was a new lint. Rename PR: #11358
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine to me :3
@bors r+ |
π |
βοΈ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Roses are red,
violets are blue,
I'm tired... π€
Oh nice, tea π΅
The cat of this release:
cc: @Centri3 & @blyxyas
As the author, I call dibs on the 1.74 cat picture π
changelog: none