Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle false positive with map_clone lint #12282

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

maekawatoshiki
Copy link
Contributor

@maekawatoshiki maekawatoshiki commented Feb 12, 2024

Summary

changelog: [map_clone]: Handle false positive with map_clone lint

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 12, 2024
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Clippy 👋

You already found the right location to edit. You ran into a difficulty with this lint, but that should be fixable. Please reach out, if you have any questions or get stuck, I'm happy to help more :D

clippy_lints/src/methods/map_clone.rs Outdated Show resolved Hide resolved
clippy_lints/src/methods/map_clone.rs Show resolved Hide resolved
@maekawatoshiki
Copy link
Contributor Author

@xFrednet Fixed the code. Let me know if something is still wrong.

@maekawatoshiki
Copy link
Contributor Author

maekawatoshiki commented Feb 19, 2024

r? xFrednet
(oh I didn't know this can't be used for already assigned people)

@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2024

Could not assign reviewer from: xFrednet.
User(s) xFrednet are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@bors
Copy link
Contributor

bors commented Feb 19, 2024

☔ The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot
Copy link
Collaborator

rustbot commented Feb 27, 2024

Failed to set assignee to xFrednet~~: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot
Copy link
Collaborator

rustbot commented Feb 27, 2024

Could not assign reviewer from: xFrednet.
User(s) xFrednet are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@xFrednet
Copy link
Member

xFrednet commented Mar 13, 2024

Hey, sorry, this PR got lost in my inbox 🙈

This version looks good, I added one comment, to your question. Once we've checked this, we can merge the PR.

@maekawatoshiki
Copy link
Contributor Author

@xFrednet Thank you for your comment. It should be okay for merge.

@xFrednet
Copy link
Member

Perfect, looks good to me, thank you for the fix :D

@bors r+

@bors
Copy link
Contributor

bors commented Mar 14, 2024

📌 Commit 5f8d8f1 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 14, 2024

⌛ Testing commit 5f8d8f1 with merge a75e271...

@bors
Copy link
Contributor

bors commented Mar 14, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing a75e271 to master...

@bors bors merged commit a75e271 into rust-lang:master Mar 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive with map_clone
4 participants