-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't emit doc_markdown
lint for missing backticks if it's inside a quote
#12472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a mini comment. Does this work with <q>
and <quote>
? It would be nice to have that, but it's not a requirement. Meow meow ✨
@@ -97,7 +104,7 @@ fn check_word(cx: &LateContext<'_>, word: &str, span: Span, code_level: isize) { | |||
} | |||
|
|||
// We assume that mixed-case words are not meant to be put inside backticks. (Issue #2343) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment like this one, but mentioning this issue? Meow meow 🐱
// We assume that mixed-case words are not meant to be put inside backticks. (Issue #2343) | |
// We assume that mixed-case words are not meant to be put inside backticks. (Issue #2343) | |
// We also assume that quotations should not be changed from the original source, so we will not lint in those. (Issue #10262) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Done.
It doesn't, I'll extend the lint to support it. |
b7b5f41
to
03d7ae8
Compare
I extended support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! ❤️
You forgot to r+ it. 😆 |
I was giving it the post-approval pass. 6th pass of my review process. bors meow meow |
What is the post-approval pass? |
The post approval pass is the "Wait lemme just re-read the PR just before merging again". It's one of the steps of my book The review process and its intricacies You have 11 reviewing steps:
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Wow, maybe I should follow your example on this. 😆 |
Fixes #10262.
changelog: Don't emit
doc_markdown
lint for missing backticks if it's inside a quote