missing_asserts_for_indexing: consider assert_eq!() as well
#14258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
| } else if let Some((macro_call, bin_op)) = | ||
| first_node_macro_backtrace(cx, expr).find_map(|macro_call| match cx.tcx.item_name(macro_call.def_id).as_str() { | ||
| "assert_eq" => Some((macro_call, BinOpKind::Eq)), | ||
| "assert_ne" => Some((macro_call, BinOpKind::Ne)), |
There was a problem hiding this comment.
I think you can use the symbols directly here (for example https://doc.rust-lang.org/nightly/nightly-rustc/rustc_span/symbol/sym/constant.assert_ne_macro.html) instead of matching on strings.
There was a problem hiding this comment.
Good point. Updated.
samueltardieu
force-pushed
the
push-oonokpytsqrp
branch
from
97ea9f9 to
0d65456
Compare
samueltardieu
force-pushed
the
push-oonokpytsqrp
branch
from
0d65456 to
e4d2a23
Compare
This comment has been minimized.
This comment has been minimized.
`assert_eq!()` and `assert_ne!()` are not expanded the same way as `assert!()` (they use a `match` instead of a `if`). This makes them being recognized as well.
samueltardieu
force-pushed
the
push-oonokpytsqrp
branch
from
e4d2a23 to
d1c315a
Compare
|
Rebased |
|
Looks like it was closed by mistake, reopening. |
|
r? clippy |
|
r? clippy |
Manishearth
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_eq!()andassert_ne!()are not expanded the same way asassert!()(they use amatchinstead of aif). This makes them being recognized as well.Fix #14255
changelog: [
missing_asserts_for_indexing]: considerassert_eq!()as well