Skip to content

Fix manual_abs_diff suggests wrongly behind refs #15265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Fix manual_abs_diff suggests wrongly behind refs #15265

merged 1 commit into from
Jul 14, 2025
+33 −6

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jul 13, 2025 •
edited
Loading

Closes #15254

changelog: [manual_abs_diff] fix wrong suggestions behind refs

@rustbot
Copy link
Collaborator

rustbot commented Jul 13, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 13, 2025
Jarcho
Jarcho approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Jarcho Jarcho added this pull request to the merge queue Jul 14, 2025
Merged via the queue into rust-lang:master with commit 43f1891 Jul 14, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarcho Jarcho Jarcho approved these changes

Assignees

@Jarcho Jarcho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

manual_abs_diff suggested fix doesn't work for borrowed values
3 participants
@profetia @rustbot @Jarcho