split cast_ptr_alignment
#15479
Merged
split cast_ptr_alignment
#15479
+14
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ada4a
force-pushed
the
split-cast-ptr-alignment
branch
from
1f16e32 to
a7516cd
Compare
ada4a
force-pushed
the
split-cast-ptr-alignment
branch
from
a7516cd to
edcb084
Compare
This comment has been minimized.
This comment has been minimized.
this allows reusing `cast_from` and `cast_to` one possible problem is that the `if` has an additional `is_hir_ty_cfg_dependant` check which the let-chain of the original `check` didn't have.. but maybe this is actually more correct
ada4a
force-pushed
the
split-cast-ptr-alignment
branch
from
edcb084 to
74be6f7
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Thank you! |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint consists of two distinct cases: one for the
ascast, and one for.cast(). Splitting them in two separate functions allowed moving theasone into theif let ExprKind::Castbranch ofcasts/mod.rs, and reusing the variables created therechangelog: none