Skip to content

ptr_arg: clean-up a bit #15507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

ptr_arg: clean-up a bit #15507

merged 1 commit into from
Aug 21, 2025

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 17, 2025

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 17, 2025
y21
y21 approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me after squash

@ada4a
ptr_arg: clean-up a bit
e4d9449 
create `Option<Region>` in a separate `filter_map`

reduces nesting a bit

replace a bunch of `and_then`s with a clearer(?) let-chain

`too_many_lines` no more!

use free-standing `zip`

add some comments
@ada4a
Copy link
Contributor Author

ada4a commented Aug 19, 2025

what is going on with these tests?..

@ada4a
Copy link
Contributor Author

ada4a commented Aug 20, 2025 •
edited
Loading

@y21 CI seems to be.. having a bad time? Could you please rerun?

@y21 y21 added this pull request to the merge queue Aug 21, 2025
Merged via the queue into rust-lang:master with commit 0039c64 Aug 21, 2025
12 of 16 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 21, 2025
@ada4a ada4a deleted the ptr_arg-cleanup branch August 21, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ada4a @rustbot @y21