Skip to content

Conversation

bend-n
Copy link
Contributor

@bend-n bend-n commented Sep 18, 2025

now lints on

let mut x = [1,2,3].into_iter();
loop {
   let Some(x) = x.next() else { break };
   dbg!(x);
}
changelog: [`while_let_loop`]: extend to lint on `let else`

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@samueltardieu
Copy link
Member

This should be auto-fixable, right?

@bend-n
Copy link
Contributor Author

bend-n commented Sep 18, 2025

in theory, yeah?

@dswij
Copy link
Member

dswij commented Sep 18, 2025

Should be auto-fixable. Let's do it in a separate PR. I created an issue for this #15702.

@bend-n would you want to help with this?

@dswij dswij added this pull request to the merge queue Oct 6, 2025
Merged via the queue into rust-lang:master with commit 4f21c99 Oct 6, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 6, 2025
@bend-n bend-n deleted the hmm branch October 6, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants