Skip to content

Fix if_then_some_else_none FP when return exists in block expr #15783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

Fix if_then_some_else_none FP when return exists in block expr #15783

merged 1 commit into from
Sep 30, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Sep 29, 2025 •
edited by rustbot
Loading

Closes #15770

changelog: [if_then_some_else_none] fix FP when return exists in block expr

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 29, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@github-actions GitHub Actions
Copy link

Lintcheck changes for 642feb7

Lint Added Removed Changed
clippy::if_then_some_else_none 0 8 1

This comment will be updated if you push new changes

Alexendoo
Alexendoo approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@Alexendoo Alexendoo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😃

View changes since this review

@Alexendoo Alexendoo added this pull request to the merge queue Sep 30, 2025
Merged via the queue into rust-lang:master with commit 3ca0738 Sep 30, 2025
11 of 13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees

@Alexendoo Alexendoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FP in clippy::if_then_some_else_none with short-circuiting ? at sole expression
3 participants
@profetia @rustbot @Alexendoo