Improve needless_pass_by_value #2117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excluding a type whose reference also fulfills the trait bound.
oli-obk
suggested changes
Oct 8, 2017
| let preds = preds | ||
| .iter() | ||
| .filter_map(|pred| if let ty::Predicate::Trait(ref poly_trait_ref) = *pred { | ||
| Some(poly_trait_ref.skip_binder()) |
There was a problem hiding this comment.
Move the filter condition from below to here as an if
| .filter(|p| !p.is_global()) | ||
| .collect() | ||
| }; | ||
| let preds = traits::elaborate_predicates(cx.tcx, cx.param_env.caller_bounds.to_vec()) |
There was a problem hiding this comment.
Why is there an intermediate vec?
|
Done. |
oli-obk
approved these changes
Oct 8, 2017
|
Thanks! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2025
While looking into #15569, I stumbled upon `clippy_utils::ptr`. This module was created in #2117, to share the logic from `ptr_arg` with `needless_pass_by_value`. But then later, #8409 removed the use of the logic from `ptr_arg`, which left `needless_pass_by_value` as the only user of this module. Still, I wanted to try to add docs to the module, but the two functions looked all too specific, so I thought it'd be better to just move them to `needless_pass_by_value`, in the hopes that whoever is looking at that lint will hopefully have enough context to understand what those functions are doing. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serde::Serializewhich has a blanket implimpl Serialize for &S where S:Serialize).ptr_arg's logic forStringandVec. Fixes needless_pass_by_value false positive with String #2114.&Stringis suggested if.capacity()is found.