Remove unsafe_vector_initialization lint #3478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lint looks for:
let mut vec = Vec::with_capacity(len);
vec.set_len(len);
The suggested replacement is `vec![0; len]`.
This is far too opinionated to be a deny-by-default lint because the performance
characteristics of the suggested replacement are totally different.
I am not convinced that this lint has value beyond what deny(unsafe_code) gives
you. Unsafe code is unsafe but please don't deny-by-default lint it if that's
the only reason.
phansch
added
the
S-waiting-on-review
|
I think we should only take out the unsafe option, since that is indeed wrong. Instead of moving the lint to |
|
I believe unsafe_vector_initialization only looks for with_capacity followed by set_len with the same argument value between the two. The other vector initialization lints are under a different lint name. Would you like me to remove unsafe_vector_initialization entirely? |
|
Yes, but you also need to register it in https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/lib.rs#L292 |
dtolnay
changed the title
|
I added unsafe_vector_initialization to deprecated and removed the implementation. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint looks for:
The suggested replacement is
vec![0; len].This is far too opinionated to be a deny-by-default lint because the performance characteristics of the suggested replacement are totally different.
I am not convinced that this lint has value beyond what deny(unsafe_code) gives you. Unsafe code is unsafe but we should not deny-by-default lint if that's the only reason.
r? collaborators involved in #3365: @flip1995 @oli-obk